Skip to content

Expose SwiftCompilerPlugin to CMake consumers #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

etcwilde
Copy link
Member

Folks working on CMake-based projects who want to use macros need to use the SwiftCompilerPlugin library. Add it as an available target.

Folks working on CMake-based projects who want to use macros need to
use the SwiftCompilerPlugin library. Add it as an available target.
@etcwilde
Copy link
Member Author

@swift-ci please test

@etcwilde
Copy link
Member Author

I don't know what this means.

--- T:\1\tools\swift\test-windows-x86_64\InterfaceHash\Output\edited_method_body.swift.tmp/b-processed.swiftdeps
***************
*** 2,8 ****
  dynamicLookup interface '' f2 true <no fingerprint>
  externalDepend interface '' 'C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.34.31933\include\vcruntime.apinotes' false <no fingerprint>
  externalDepend interface '' 't:\1\lib\swift\windows\Swift.swiftmodule\x86_64-unknown-windows-msvc.swiftmodule' false <no fingerprint>
! externalDepend interface '' 't:\1\lib\swift\windows\_Concurrency.swiftmodule\x86_64-unknown-windows-msvc.swiftmodule' false <no fingerprint>
  externalDepend interface '' 't:\1\lib\swift\windows\_StringProcessing.swiftmodule\x86_64-unknown-windows-msvc.private.swiftinterface' false <no fingerprint>
  member interface 4main1CC Int false <no fingerprint>
  member interface 4main1CC deinit false <no fingerprint>
--- 2,8 ----
  dynamicLookup interface '' f2 true <no fingerprint>
  externalDepend interface '' 'C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.34.31933\include\vcruntime.apinotes' false <no fingerprint>
  externalDepend interface '' 't:\1\lib\swift\windows\Swift.swiftmodule\x86_64-unknown-windows-msvc.swiftmodule' false <no fingerprint>
! externalDepend interface '' 't:\1\lib\swift\windows\_Concurrency.swiftmodule\x86_64-unknown-windows-msvc.private.swiftinterface' false <no fingerprint>
  externalDepend interface '' 't:\1\lib\swift\windows\_StringProcessing.swiftmodule\x86_64-unknown-windows-msvc.private.swiftinterface' false <no fingerprint>
  member interface 4main1CC Int false <no fingerprint>
  member interface 4main1CC deinit false <no fingerprint>

error: command failed with exit status: 1
--

@etcwilde
Copy link
Member Author

@swift-ci please clean test Windows platform

@etcwilde
Copy link
Member Author

😒 Windows, get yourself together please.

C:/Users/swift-ci/jenkins/workspace/swift-syntax-PR-windows/swift/stdlib/public/Distributed/DistributedActorSystem.swift:385:26: error: reference to undefined version '5.11' for availability macro 'SwiftStdlib'
  @available(SwiftStdlib 5.11, *)
                         ^

@etcwilde
Copy link
Member Author

@swift-ci please test Windows platform

@ahoppen
Copy link
Member

ahoppen commented Feb 23, 2024

@swift-ci Please test Windows

Comment on lines +10 to +11
CompilerPlugin.swift
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CompilerPlugin.swift
)
CompilerPlugin.swift)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am matching the style of the project. File lists have a newline before the closing paren. See https://github.com/apple/swift-syntax/blob/main/Sources/SwiftSyntax/CMakeLists.txt, etc...

@etcwilde etcwilde merged commit 247e3ce into swiftlang:main Feb 26, 2024
@etcwilde etcwilde deleted the ewilde/expose-compiler-plugins branch February 26, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants