Allow return types on initializers #2541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
ahoppen
changed the title
SE-2305 allows returning `Self` and `Self?` from initializers so that the return type can be annotated with `_borrow(a)` etc. So we need to allow return clauses on initializers. rdar://123905900
ahoppen
force-pushed
the
ahoppen/return-type-on-initializer
branch
from
14a867b to
3e368ca
Compare
|
@swift-ci Please test |
bnbarham
approved these changes
Mar 15, 2024
|
Note that this should probably go behind experimental |
|
I don’t think it needs to be behind an experimental flag because the syntax tree has always allowed return types on initializers. |
This was referenced Mar 20, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SE-2305 allows returning
SelfandSelf?from initializers so that the return type can be annotated with_borrow(a)etc.So we need to allow return clauses on initializers.
rdar://123905900