Skip to content

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Apr 24, 2021

No description provided.

@@ -150,13 +149,13 @@ public struct ${node.syntax_kind}: SyntaxBuildable {
self.elements = elements
}

public func build${node.syntax_kind}(format: Format, leadingTrivia: Trivia? = nil) -> ${node.syntax_kind}Syntax {
public func build${node.syntax_kind}(format: Format) -> ${node.syntax_kind}Syntax {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leadingTrivia was never used 🤦‍♂️

@kimdv kimdv force-pushed the kimdv/code-cleaning branch from 3d09224 to fdbd6e5 Compare April 26, 2021 06:18
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick, otherwise looks good to me. Thanks for cleaning it up.

@kimdv kimdv force-pushed the kimdv/code-cleaning branch from fdbd6e5 to c247962 Compare April 26, 2021 08:45
@kimdv kimdv requested a review from ahoppen April 26, 2021 08:53
@ahoppen
Copy link
Member

ahoppen commented Apr 26, 2021

@swift-ci Please test

@ahoppen ahoppen merged commit 3aef974 into swiftlang:main Apr 26, 2021
@kimdv kimdv deleted the kimdv/code-cleaning branch May 2, 2021 18:20
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Support `async` and `throws` on property/subscript getters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants