Omit parameters in init that is optional #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Apr 29, 2021
| % for child_param in child_params: | ||
| let ${child_param} | ||
| % for let_variable in let_variables: | ||
| let ${let_variable} |
There was a problem hiding this comment.
Since we are no longer using let_variables for the initializer, I think we can just print the straight away instead of storing them in an array first.
There was a problem hiding this comment.
Done! That was a little brain fart! 🤦♂️
kimdv
force-pushed
the
kimdv/omit-optional-init-parameters
branch
2 times, most recently
from
c5e6017 to
d41ecad
Compare
kimdv
force-pushed
the
kimdv/omit-optional-init-parameters
branch
from
d41ecad to
dae0f99
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.