[Experimental] Add Embedded Swift support to the _TestDiscovery target.
#1043
+136
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
grynspan
force-pushed
the
jgrynspan/test-discovery-embedded
branch
2 times, most recently
from
e56d806 to
c7c0810
Compare
This PR adds preliminary/experimental support for Embedded Swift _to the `_TestDiscovery` target only_ when building Swift Testing as a package. To try it out, you must set the environment variable `SWT_EMBEDDED` to `true` before building. Tested with the following incantation using the 2025-03-28 main-branch toolchain: ```sh SWT_EMBEDDED=1 swift build --target _TestDiscovery --triple arm64-apple-macosx ```
grynspan
force-pushed
the
jgrynspan/test-discovery-embedded
branch
from
c7c0810 to
0f49e73
Compare
|
@swift-ci test |
grynspan
commented
Mar 30, 2025
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test |
hrayatnia
reviewed
Apr 8, 2025
grynspan
changed the title
_TestDiscovery target._TestDiscovery target.
|
@swift-ci test |
stmontgomery
reviewed
Apr 8, 2025
stmontgomery
approved these changes
Apr 8, 2025
2 tasks
stmontgomery
added a commit
that referenced
this pull request
Apr 17, 2025
… when building for non-Embedded without a fallback condition (#1081) This fixes an unintended side effect from #1043 where the `SWT_NO_LEGACY_TEST_DISCOVERY` compilation conditional was being applied when building for non-Embedded. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds preliminary/experimental support for Embedded Swift to the
_TestDiscoverytarget only when building Swift Testing as a package. To try it out, you must set the environment variableSWT_EMBEDDEDtotruebefore building.Tested with the following incantation using the 2025-03-28 main-branch toolchain:
Checklist: