Skip to content

[6.2] Add signal handler for SIGABRT_COMPAT on Windows. #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Apr 7, 2025

The special-case signal handling implemented for Windows doesn't
currently set a handler for `SIGABRT_COMPAT` (which is a synonym of
`SIGABRT` with a different value.) This PR adds it to the list of
signals we install handlers for.

### Checklist:

- [x] Code and documentation should follow the style of the [Style
Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md).
- [x] If public symbols are renamed or modified, DocC references should
be updated.
@grynspan grynspan added bug 🪲 Something isn't working windows 🪟 Windows support exit-tests ☠️ Work related to exit tests labels Apr 7, 2025
@grynspan grynspan added this to the Swift 6.2 milestone Apr 7, 2025
@grynspan grynspan self-assigned this Apr 7, 2025
@grynspan
Copy link
Contributor Author

grynspan commented Apr 8, 2025

@swift-ci test

@grynspan grynspan requested a review from compnerd April 8, 2025 04:21
@grynspan grynspan merged commit e99d47e into release/6.2 Apr 8, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/SIGABRT_COMPAT-windows-6.2 branch April 8, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working exit-tests ☠️ Work related to exit tests windows 🪟 Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants