Skip to content

Add a cross-import overlay with CoreImage to allow attaching CIImages. #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 9, 2025
Merged

Add a cross-import overlay with CoreImage to allow attaching CIImages. #1195

merged 8 commits into from
Jul 9, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Jul 2, 2025 •
edited
Loading

This PR adds on to the Core Graphics cross-import overlay added in #827 to allow attaching instances of CIImage to a test.

Note

Image attachments remain an experimental feature.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Add a cross-import overlay with CoreImage to allow attaching CIImages.
264f6f9 
This PR adds on to the Core Graphics cross-import overlay added in #827 to allow
attaching instances of `CIImage` to a test.

> [!NOTE]
> Image attachments remain an experimental feature.
@grynspan grynspan added this to the Swift 6.x (main) milestone Jul 2, 2025
@grynspan grynspan self-assigned this Jul 2, 2025
@grynspan grynspan added enhancement New feature or request darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support public-api Affects public API attachments/activities 🖇️ Work related to attachments and/or activities cross-import-overlays 🍰 Cross-import overlays (Foundation, Core Graphics, etc.) labels Jul 2, 2025
@grynspan
Copy link
Contributor Author

grynspan commented Jul 2, 2025

@swift-ci test

@grynspan
Copy link
Contributor Author

grynspan commented Jul 2, 2025

@swift-ci test

@grynspan
Copy link
Contributor Author

grynspan commented Jul 2, 2025

@swift-ci test

@grynspan
Copy link
Contributor Author

grynspan commented Jul 2, 2025

@swift-ci test

@grynspan
Copy link
Contributor Author

grynspan commented Jul 9, 2025

@swift-ci test

@grynspan
Copy link
Contributor Author

grynspan commented Jul 9, 2025

@swift-ci test

@grynspan grynspan merged commit e245c54 into main Jul 9, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/ciimage-attachments branch July 9, 2025 17:31
stmontgomery
stmontgomery reviewed Jul 9, 2025
View reviewed changes
Copy link
Contributor

@stmontgomery stmontgomery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@grynspan grynspan added the image-attachments 📸 Work related to image attachments label Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery left review comments

@suzannaratcliff suzannaratcliff suzannaratcliff approved these changes

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

Assignees

@grynspan grynspan

Labels
attachments/activities 🖇️ Work related to attachments and/or activities cross-import-overlays 🍰 Cross-import overlays (Foundation, Core Graphics, etc.) darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support enhancement New feature or request image-attachments 📸 Work related to image attachments public-api Affects public API
Projects
None yet
Milestone
Swift 6.x (main)
Development

Successfully merging this pull request may close these issues.
3 participants
@grynspan @stmontgomery @suzannaratcliff