Harmonize _AttachableImageWrapper and AttachableAs___ across Darwin and Windows.
#1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in and Windows. This PR makes some changes to harmonize the `_AttachableImageWrapper` wrapper type and the `AttachableAsCGImage`/`AttachableAsIWICBitmap` protocols across Darwin and Windows: - `_AttachableImageWrapper` is now a class on both platforms, not just Windows. - The `_makeCopyForAttachment()` function is now named `_copyAttachableValue()` (which is a more accurate name already used on Windows.) - A default implementation of `_copyAttachableValue()` and of `_deinitializeAttachableValue()` is provided for `Sendable` types on Windows.
grynspan
added
public-api
|
@swift-ci test |
|
@swift-ci test |
grynspan
commented
Aug 11, 2025
Sources/Overlays/_Testing_WinSDK/Attachments/AttachableImageFormat+CLSID.swift
Outdated
Show resolved
Hide resolved
compnerd
approved these changes
Aug 11, 2025
|
@swift-ci test |
stmontgomery
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some changes to harmonize the
_AttachableImageWrapperwrapper type and theAttachableAsCGImage/AttachableAsIWICBitmapprotocols across Darwin and Windows:_AttachableImageWrapperis now a class on both platforms, not just Windows._makeCopyForAttachment()function is now named_copyAttachableValue()(which is a more accurate name already used on Windows.)_copyAttachableValue()and of_deinitializeAttachableValue()is provided forSendabletypes on Windows.Checklist: