Reduce duplicated code between Darwin's and Windows' image attachments. #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR cleans up the implementations of image attachments on Darwin and Windows so that we have less code duplication between the two. `_AttachableImageWrapper` is partially lowered to the main library (excepting the platform-specific bits) and `ImageAttachmentError` is lowered in its entirety. There are some adjustments to the (internal/package) interface of `_AttachableImageWrapper` to accomodate it not being able to specify conformance to `AttachableAsCGImage` or `AttachableAsIWICBitmapSource`. Namely, whatever code initializes an instance of it is responsible for copying `image` and providing a deinitializer function as needed.
grynspan
added
windows
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test Windows |
|
@swift-ci test |
|
@swift-ci test macOS |
|
@swift-ci test Linux |
|
@swift-ci test |
|
@swift-ci test Windows |
grynspan
requested review from
briancroom,
stmontgomery and
suzannaratcliff
as code owners
Sources/Overlays/_Testing_CoreGraphics/Attachments/AttachableAsCGImage.swift
Show resolved
Hide resolved
…ntation shows both even if the WinSDK module isn't being built
|
@swift-ci test |
|
@swift-ci test |
stmontgomery
approved these changes
Aug 18, 2025
|
@swift-ci test |
|
@swift-ci test |
|
Untested changes are just comment typo fixes. Merging. |
grynspan
deleted the
jgrynspan/reduce-code-duplication-in-image-attachments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the implementations of image attachments on Darwin and Windows so that we have less code duplication between the two.
_AttachableImageWrapperis partially lowered to the main library (excepting the platform-specific bits) andImageAttachmentErroris lowered in its entirety.There are some adjustments to the (internal/package) interface of
_AttachableImageWrapperto accomodate it not being able to specify conformance toAttachableAsCGImageorAttachableAsIWICBitmapSource. Namely, whatever code initializes an instance of it is responsible for copyingimageand providing a deinitializer function as needed.Checklist: