Skip to content

Enable license header soundness check #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2025
Merged

Enable license header soundness check #1312

merged 2 commits into from
Sep 11, 2025

Conversation

stmontgomery
Copy link
Contributor

Enable the (currently-disabled) license header soundness check via GitHub Actions. I expect this will fail, but I'm trying to first understand what the failures are so we can hopefully resolve them and enable this.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@stmontgomery stmontgomery added this to the Swift 6.x (main) milestone Sep 11, 2025
@stmontgomery stmontgomery self-assigned this Sep 11, 2025
@stmontgomery stmontgomery added documentation 📚 Improvements or additions to documentation enhancement New feature or request build 🧱 Affects the project's build configuration or process labels Sep 11, 2025
@stmontgomery
Copy link
Contributor Author

See also: swiftlang/github-workflows#158

@stmontgomery stmontgomery force-pushed the license-header-soundness-check branch from 95becee to 90853d7 Compare September 11, 2025 21:16
@stmontgomery stmontgomery marked this pull request as ready for review September 11, 2025 21:25
jerryjrchen
jerryjrchen approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@jerryjrchen jerryjrchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stmontgomery stmontgomery merged commit 77f84d3 into swiftlang:main Sep 11, 2025
18 checks passed
@stmontgomery stmontgomery deleted the license-header-soundness-check branch September 11, 2025 22:59
@stmontgomery stmontgomery mentioned this pull request Sep 11, 2025
Closed
@stmontgomery stmontgomery linked an issue Sep 11, 2025 that may be closed by this pull request
[CI] Enable License, Docs, Unacceptable language, and Format checks #1309
Closed
@stmontgomery stmontgomery mentioned this pull request Sep 12, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryjrchen jerryjrchen jerryjrchen approved these changes

@grynspan grynspan Awaiting requested review from grynspan grynspan is a code owner

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@stmontgomery stmontgomery

Labels
build 🧱 Affects the project's build configuration or process documentation 📚 Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Swift 6.x (main)
Development

Successfully merging this pull request may close these issues.

[CI] Enable License, Docs, Unacceptable language, and Format checks
2 participants
@stmontgomery @jerryjrchen