Skip to content

Apply changes from ST-NNNN. #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: jgrynspan/promote-windows-image-attachments-to-api
Choose a base branch
from
Draft

Apply changes from ST-NNNN. #1359

wants to merge 2 commits into from

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Oct 7, 2025 •
edited
Loading

This PR applies the changes from ST-NNNN. It merges AttachableAsCGImage and AttachableAsIWICBitmapSource into a single AttachableAsImage protocol and it adjusts the interfaces of AttachableImageFormat and Attachment where AttachableValue: AttachableAsImage.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Revert "Reapply "Remove workaround for swiftlang/swift#84466""
16682c9 
This reverts commit e5f0002.
@grynspan
Apply changes from ST-NNNN.
dfb61b4 
This PR applies the changes from [ST-NNNN](swiftlang/swift-evolution#2985).
It merges `AttachableAsCGImage` and `AttachableAsIWICBitmapSource` into a single
`AttachableAsImage` protocol and it adjusts the interfaces of
`AttachableImageFormat` and `Attachment where AttachableValue: AttachableAsImage`.
@grynspan grynspan added this to the Swift 6.x (main) milestone Oct 7, 2025
@grynspan grynspan self-assigned this Oct 7, 2025
@grynspan grynspan added enhancement New feature or request windows 🪟 Windows support darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support public-api Affects public API attachments/activities 🖇️ Work related to attachments and/or activities image-attachments 📸 Work related to image attachments labels Oct 7, 2025
@grynspan grynspan mentioned this pull request Oct 7, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery will be requested when the pull request is marked ready for review stmontgomery is a code owner

@briancroom briancroom Awaiting requested review from briancroom briancroom will be requested when the pull request is marked ready for review briancroom is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff will be requested when the pull request is marked ready for review suzannaratcliff is a code owner

@jerryjrchen jerryjrchen Awaiting requested review from jerryjrchen jerryjrchen will be requested when the pull request is marked ready for review jerryjrchen is a code owner

Assignees

@grynspan grynspan

Labels
attachments/activities 🖇️ Work related to attachments and/or activities darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support enhancement New feature or request image-attachments 📸 Work related to image attachments public-api Affects public API windows 🪟 Windows support
Projects
None yet
Milestone
Swift 6.x (main)
Development

Successfully merging this pull request may close these issues.
1 participant
@grynspan