Apply suite diagnostics to the entire lexical context. #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR applies all suite diagnostics\* to every decl group (declaring type or
extension) in the lexical context during `@Suite` and `@Test` expansion. For
example:
```swift
struct S1<T> {
@suite struct S2 { // 🛑 Attribute 'Suite' cannot be applied to a generic structure
@test func f() {} // 🛑 Attribute 'Test' cannot be applied to a generic function
}
}
```
This PR is follow-up to #332 and #333.
\* Except for diagnostics specific to the `@Suite` attribute itself.
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
grynspan
commented
Apr 8, 2024
| @@ -189,7 +189,7 @@ struct DiagnosticMessage: SwiftDiagnostics.DiagnosticMessage { | |||
| /// - Returns: A diagnostic message. | |||
| static func genericDeclarationNotSupported(_ decl: some SyntaxProtocol, whenUsing attribute: AttributeSyntax, becauseOf genericClause: some SyntaxProtocol) -> Self { | |||
| Self( | |||
| syntax: Syntax(genericClause), | |||
| syntax: (genericClause.root != decl.root) ? Syntax(decl) : Syntax(genericClause), | |||
There was a problem hiding this comment.
Nodes from the lexical context are detached, so diagnostics applied to them don't align to any real source location. This check is only (currently) needed here since we use this diagnostic unmodified for both code paths and prefer that the diagnostic point to the generic clause rather than the affected symbol.
|
@swift-ci please test |
dennisweissmann
approved these changes
Apr 8, 2024
|
@swift-ci please test |
|
@swift-ci please test |
grynspan
deleted the
jgrynspan/apply-suite-diagnostics-to-lexical-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies all suite diagnostics* to every decl group (declaring type or extension) in the lexical context during
@Suiteand@Testexpansion. For example:This PR is follow-up to #332 and #333.
* Except for diagnostics specific to the
@Suiteattribute itself.Checklist: