Require that .bug() identifiers be parseable as URLs.
#347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
|
@swift-ci please test Linux |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@compnerd Mind sanity-checking the Win32 code here? Thanks! |
compnerd
reviewed
Apr 12, 2024
Sources/TestingMacros/Support/DiagnosticMessage+Diagnosing.swift
Outdated
Show resolved
Hide resolved
Sources/TestingMacros/Support/DiagnosticMessage+Diagnosing.swift
Outdated
Show resolved
Hide resolved
|
@swift-ci please test |
|
@swift-ci please test |
compnerd
reviewed
Apr 15, 2024
Sources/TestingMacros/Support/Additions/EditorPlaceholderExprSyntaxAdditions.swift
Show resolved
Hide resolved
compnerd
approved these changes
Apr 15, 2024
This PR constrains the valid values of `.bug()` identifiers. They must now be valid URLs or, as a fallback, valid unsigned integers. Arbitrary strings were never intended to be supported.
grynspan
force-pushed
the
jgrynspan/type-check-bug-identifiers
branch
from
6158b8c to
b950b50
Compare
|
@swift-ci please test |
|
@swift-ci please test |
briancroom
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR constrains the valid values of
.bug()identifiers. They must now be valid URLs or, as a fallback, valid unsigned integers. Arbitrary strings were never intended to be supported.Checklist: