Abstract away our dependency on Foundation for JSON encoding/decoding #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves all our uses of `JSONEncoder` and `JSONDecoder` to a new namespace enum, `JSON`, and provides interfaces that don't use Foundation. This change does _not_ remove our dependency on Foundation's JSON functionality, but it should allow us to replace that functionality in the future with JSON encoding/decoding logic from another library (or home-grown, if necessary.)
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
|
@swift-ci please test Linux |
|
Linux failure is because we've removed some Foundation imports (which reexport Glibc, I guess.) Explicitly adding the necessary headers to Includes.h. |
|
@swift-ci please test |
briancroom
approved these changes
Apr 16, 2024
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
stmontgomery
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all our uses of
JSONEncoderandJSONDecoderto a new namespace enum,JSON, and provides interfaces that don't use Foundation.This change does not remove our dependency on Foundation's JSON functionality, but it should allow us to replace that functionality in the future with JSON encoding/decoding logic from another library (or home-grown, if necessary.)
Checklist: