Always set the XCTest bundle path on Darwin when running exit tests. #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xcode is a complicated beast and there are code paths that lead to us running a test hosted by XCTest that isn't discoverable by the existing exit test implementation. This PR makes that implementation more robust in these scenarios and fixes spurious exit test failures that were resulting.
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
grynspan
commented
May 17, 2024
| @@ -95,6 +95,10 @@ | |||
| #include <wasi/libc-environ.h> | |||
| #endif | |||
|
|
|||
| #if __has_include(<libgen.h>) | |||
| #include <libgen.h> | |||
briancroom
approved these changes
May 17, 2024
|
Windows failure is a known issue in the compiler. |
grynspan
deleted the
jgrynspan/exit-tests-always-set-xctest-bundle-when-hosted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode is a complicated beast and there are code paths that lead to us running a test hosted by XCTest that isn't discoverable by the existing exit test implementation. This PR makes that implementation more robust in these scenarios and fixes spurious exit test failures that were resulting.
Checklist: