Skip to content

Fix a typo in the documentation for TimeLimitTrait. #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2024
Merged

Fix a typo in the documentation for TimeLimitTrait. #432

merged 1 commit into from
May 23, 2024

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented May 23, 2024 •
edited
Loading

Takes .seconds(), not .minutes() as of #391.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Fix a typo in the documentation for TimeLimitTrait.
cf977fd 
Takes `.seconds()`, not `.minutes()` as of #391.
@grynspan grynspan added bug 🪲 Something isn't working documentation 📚 Improvements or additions to documentation labels May 23, 2024
@grynspan grynspan self-assigned this May 23, 2024
@grynspan
Copy link
Contributor Author

Documentation change only. Skipping CI.

@grynspan grynspan merged commit 004994f into main May 23, 2024
@grynspan grynspan deleted the jgrynspan/time-limit-takes-minutes-not-seconds-docs branch May 23, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisweissmann dennisweissmann dennisweissmann approved these changes

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working documentation 📚 Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grynspan @stmontgomery @dennisweissmann