Skip to content

Update CMake settings to match recent package changes #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2024
Merged

Update CMake settings to match recent package changes #497

merged 2 commits into from
Jun 20, 2024

Conversation

stmontgomery
Copy link
Contributor

A few fixes to the CMake and package build settings:

  • Enable Swift 6 language mode, to match the package which now uses this language mode due to the change which bumped swift-tools-version to 6.0.
  • Add SourceLocation macro-related source files, which were missing.
  • Add fake visionOS 99.0 OS version to our _distantFuture availability definition.
  • Clean up experimental/upcoming features which are no longer needed.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@stmontgomery
Update CMake settings to match recent package changes
67cfcbd 
- Enable Swift 6 language mode, to match the package which now uses this language mode due to the change which bumped `swift-tools-version` to 6.0.
- Add SourceLocation macro-related source files, which were missing.
- Add fake `visionOS 99.0` OS version to our `_distantFuture` availability definition.
- Clean up experimental/upcoming features which are no longer needed.
@stmontgomery stmontgomery added the bug 🪲 Something isn't working label Jun 20, 2024
@stmontgomery stmontgomery self-assigned this Jun 20, 2024
@stmontgomery
Copy link
Contributor Author

@swift-ci please test

@stmontgomery
Copy link
Contributor Author

@compnerd @jeffdav FYI about these adjustments to the CMake rules.

compnerd
compnerd approved these changes Jun 20, 2024
View reviewed changes
@stmontgomery
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@stmontgomery
Copy link
Contributor Author

@swift-ci please test

@stmontgomery stmontgomery merged commit 8983930 into swiftlang:main Jun 20, 2024
@stmontgomery stmontgomery deleted the update-cmake-settings branch June 20, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@briancroom briancroom briancroom approved these changes

@grynspan grynspan Awaiting requested review from grynspan grynspan is a code owner

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@stmontgomery stmontgomery

Labels
bug 🪲 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stmontgomery @compnerd @briancroom