[6.0] Explicitly link to Foundation in CMake builds
#709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
requested review from
stmontgomery,
grynspan,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
Did you mean to cherry-pick this to release/6.0.1? |
bnbarham
approved these changes
Sep 18, 2024
stmontgomery
approved these changes
Sep 20, 2024
stmontgomery
added
bug
briancroom
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #693 into
release/6.0Foundationwas not in the regular search directory (e.g. resource directory or SDK search paths)#if canImport(Foundation)used to fail, and the functionalities are not included. This patch provides a way to provideFoundation_DIRforfind_packgage(Foundation CONFIG), so that clients can correctly link Testing to Foundation