Skip to content

Fix posix_spawn() error handling. #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix posix_spawn() error handling. #855

merged 1 commit into from
Dec 12, 2024

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Dec 12, 2024 •
edited
Loading

posix_spawn() does not (portably) set errno. Instead, it returns its error code. Fix our call.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Fix posix_spawn() error handling.
48fd8d7 
`posix_spawn()` does not (portably) set `errno`. Instead, it returns its error code. Fix
our call.
@grynspan grynspan added bug 🪲 Something isn't working linux 🐧 Linux support (all distros) darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support exit-tests ☠️ Work related to exit tests freebsd 😈 FreeBSD support labels Dec 12, 2024
@grynspan grynspan self-assigned this Dec 12, 2024
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan merged commit a239222 into main Dec 12, 2024
3 checks passed
@grynspan grynspan deleted the jgrynspan/fix-posix-spawn-error-handling branch December 12, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support exit-tests ☠️ Work related to exit tests freebsd 😈 FreeBSD support linux 🐧 Linux support (all distros)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grynspan @stmontgomery