Skip to content

Fix several compile-time warnings that have snuck in. #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix several compile-time warnings that have snuck in. #899

merged 1 commit into from
Jan 8, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Jan 8, 2025 •
edited
Loading

This PR resolves some compile-time warnings that occur when building the package from source. None of these warnings are critical issues.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Fix several compiler warnings that have snuck in.
749d0b9 
This PR resolves some compiler warnings that occur when building the package from source. None of these warnings are critical issues.
@grynspan grynspan added bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process labels Jan 8, 2025
@grynspan grynspan self-assigned this Jan 8, 2025
@grynspan
Copy link
Contributor Author

grynspan commented Jan 8, 2025

@swift-ci test

@grynspan grynspan changed the title Fix several compiler warnings that have snuck in. Fix several compile-time warnings that have snuck in. Jan 8, 2025
@grynspan
Copy link
Contributor Author

grynspan commented Jan 8, 2025

@swift-ci test Linux

@grynspan grynspan merged commit 89ff719 into main Jan 8, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/2025-01-08-compiler-warnings branch January 8, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grynspan @stmontgomery