-
Notifications
You must be signed in to change notification settings - Fork 121
Fix building on FreeBSD via cmake #925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I assume you've tested this? |
@swift-ci test |
yup, I compiled a toolchain with the change and tested on a random swift project (in this case, swift-crypto) and verified swift-testing is loading.
|
We obviously don't have any CI set up for FreeBSD, but please wait until the CI we do have is done before merging. |
@swift-ci test |
Feel free to merge once CI is green—if you don't have the Big Green Button yet, send me a DM and I'll do it. |
@swift-ci test Windows |
Currently building swift-testing via cmake (e.g. when building the toolchain) fail if not compile as PIC. Adding "-fPIC" fixed this problem. Moreover, we need to link against
libexecinfo
on FreeBSD where the symbolbacktrace
lives.Result:
Swift testing can now successfully build via cmake thus installed to the toolchain 🥳