Skip to content

Missing an explicit include of <mach-o/dyld.h> on Apple platforms. #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

Missing an explicit include of <mach-o/dyld.h> on Apple platforms. #932

merged 1 commit into from
Jan 28, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Jan 28, 2025 •
edited
Loading

On some Apple platforms (e.g. iOS), the set of includes we have in _TestingInternals doesn't transitively include dyld.h, causing a build failure when building for those platforms. So explicitly include it.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Missing an explicit include of <mach-o/dyld.h> on Apple platforms.
4a2fdc3 
On some Apple platforms (e.g. iOS), the set of includes we have in
`_TestingInternals` doesn't transitively include dyld.h, causing a build
failure when building for those platforms. So explicitly include it.
@grynspan grynspan added bug 🪲 Something isn't working darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support labels Jan 28, 2025
@grynspan grynspan added this to the Swift 6.x milestone Jan 28, 2025
@grynspan grynspan self-assigned this Jan 28, 2025
@grynspan grynspan added the workaround Workaround for an issue in another component (may need to revert later) label Jan 28, 2025
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

Change won't affect Windows, so I'm merging this before Windows CI completes. 😇

@grynspan grynspan merged commit 0da75fa into main Jan 28, 2025
2 of 3 checks passed
@grynspan grynspan deleted the jgrynspan/missing-dyld-h-include branch January 28, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support workaround Workaround for an issue in another component (may need to revert later)
Projects
None yet
Milestone
Swift 6.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@grynspan @stmontgomery