Skip to content

Rename ExitTestArtifacts and split ExitCondition in twain. #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 28, 2025
Merged

Rename ExitTestArtifacts and split ExitCondition in twain. #975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1816350
Rename `ExitTestArtifacts` and split `ExitCondition` in twain.
grynspan Feb 25, 2025
a872212
Missed a Windows-specific .failure usage
grynspan Feb 26, 2025
a265536
Fix typo in DocC comment
grynspan Feb 26, 2025
ae3939d
Incorporate feedback
grynspan Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Sources/Testing/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,11 @@ add_library(Testing
Events/Recorder/Event.JUnitXMLRecorder.swift
Events/Recorder/Event.Symbol.swift
Events/TimeValue.swift
ExitTests/ExitCondition.swift
ExitTests/ExitTest.swift
ExitTests/ExitTestArtifacts.swift
ExitTests/ExitTest.Condition.swift
ExitTests/ExitTest.Result.swift
ExitTests/SpawnProcess.swift
ExitTests/StatusAtExit.swift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned in the PR description this type may be used independently of exit tests, so I'm wondering if the file ought to be placed in a different directory to emphasize that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can move, but the code is already in this directory so for now I was planning to leave it there. Do you feel strongly?

ExitTests/WaitFor.swift
Expectations/Expectation.swift
Expectations/Expectation+Macro.swift
Expand Down
236 changes: 0 additions & 236 deletions Sources/Testing/ExitTests/ExitCondition.swift
View file
Open in desktop

This file was deleted.

Loading