[SR-10469] Unknown syntax for interpolated string literal

[rintaro]

Previous ID	SR-10469
Radar	rdar://problem/49855746
Original Reporter	@rintaro
Type	Bug
Status	Resolved
Resolution	Done

Environment

swift master (77a79f2)

Additional Detail from JIRA

Votes	0
Component/s	Compiler
Labels	Bug, Syntax
Assignee	kitasuke (JIRA)
Priority	Medium

md5: 7bc00c2f480ca5381d03eef3740968c6

relates to:

• SR-10241 A way to get raw string without quotes from StringLiteralExprSyntax

Issue Description:

"\(1, foo: 2)"

$ swift-syntax-test -parse-gen -input-source-filename test.swift
test.swift:1:1: error: unknown expression syntax exists in the source
"\(1, foo: 2)"
^
"\(1, foo: 2)"

[rintaro]

https://github.com/apple/swift/blob/77a79f236bc8d558d8ec926d13086a2739860bed/utils/gyb_syntax_support/ExprNodes.py#L455-L465

    # expression segment in a string interpolation expression.
    Node('ExpressionSegment', kind='Syntax',
         traits=['Parenthesized'],
         children=[
             Child('Backslash', kind='BackslashToken'),
             Child('LeftParen', kind='LeftParenToken',
                   classification='StringInterpolationAnchor',
                   force_classification=True),
             Child('Expression', kind='Expr'),
             Child('RightParen', kind='StringInterpolationAnchorToken'),
         ]),

The expression part should be FunctionCallArgumentList as per SE-0228

[rintaro]

kitasuke (JIRA User) Are you interested in fixing this too?

[swift-ci]

Comment by Yusuke Kita (JIRA)

Yes, let me look into this.

[rintaro]

master: #24280 -> #24398
swift-5.1-branch: #24846