Windows Toolchain Build Failing

[dschaefer2]

Description

Windows toolchains builds are failing,
e.g. https://ci-external.swift.org/job/swift-main-windows-toolchain/1617/console

10:53:07  C:\Windows\system32\cmd.exe /C "cd . && T:\5\bin\swiftc.exe -target aarch64-unknown-linux-android -j 36 -num-threads 36 -emit-library -o libXCTest.so -module-name XCTest -module-link-name XCTest -emit-module -emit-module-path swift\XCTest.swiftmodule -emit-dependencies -DXCTest_EXPORTS -sdk "T:/Program Files/Swift/Platforms/Android.platform/Developer/SDKs/Android.sdk" -sysroot T:/android-ndk-r27c/toolchains/llvm/prebuilt/windows-x86_64/sysroot -Xclang-linker -target -Xclang-linker aarch64-unknown-linux-android28 -Xclang-linker --sysroot -Xclang-linker T:/android-ndk-r27c/toolchains/llvm/prebuilt/windows-x86_64/sysroot -Xclang-linker -resource-dir -Xclang-linker T:/android-ndk-r27c/toolchains/llvm/prebuilt/windows-x86_64/lib/clang/18 -Xclang-linker -L -Xclang-linker "T:/Program Files/Swift/Platforms/Android.platform/Developer/SDKs/Android.sdk/usr/lib/swift/android/aarch64" -gnone -O -output-file-map CMakeFiles\XCTest.dir\Release\output-file-map.json  @CMakeFiles\XCTest.rsp -no-toolchain-stdlib-rpath -Xlinker --build-id=sha1 -Xlinker -soname -Xlinker libXCTest.so  && cd ."
10:53:07  <unknown>:0: warning: using (deprecated) legacy driver, Swift installation does not contain swift-driver at: 'C:\Users\swift-ci\jenkins\workspace\swift-main-windows-toolchain\build\5\bin\swift-driver-new.exe'
10:53:07  <unknown>:0: error: cannot load underlying module for 'Dispatch'

Appears to be in the Android SDK build. @compnerd or someone from the Android working group take a look?

Reproduction

It's a failure in the toolchain build.

Expected behavior

No failure.

Environment

https://ci-external.swift.org/job/swift-main-windows-toolchain/1617/console

Additional information

No response

[shahmishal]

Might be related to #84306

[artemcm]

@Steelskin, @compnerd, this is blocking Windows toolchains at the moment, any idea on this or who may be the right person to see if reverting #84306 is the way forward?

[Steelskin]

I'm fine with reverting if this is urgent as I won't have the time to look into this until tomorrow (EST). I'll take a look first thing in the morning.

[compnerd]

This is hiding 2 subsequent issues - I'm looking into it, I think I can fix forward.

[compnerd]

#84505 should fix most of the issues, but it might be insufficient. The build of swift-inspect seems to be missing -llog locally for Android.

[compnerd]

I've separately fixed the linking issue, but it seems that CI is still not getting through but I'm not able to reproduce the issue locally. I'm trying again with a clean build.

[compnerd]

Seems that the CI is failing still due to the header search path for dispatch. I think that #84572 should help with that, but we do not have a way to validate that in CI. (I wonder if I didn't hit this originally due to the revert that @artemcm had in flight)

[artemcm]

Looks like we got a green build!
https://ci-external.swift.org/job/swift-main-windows-toolchain/1629/

[compnerd]

Yeah, I think that I just fixed it up last night.

[artemcm]

Thank you!