[4.0] [PrintAsObjC] Handle the importer's compatibility typealiases #10046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrose-apple
commented
Jun 1, 2017
jrose-apple
commented
- Explanation: If an imported type has been renamed between Swift 3 and Swift 4, both names are available for use in Swift 3.2, with the "old" name being a typealias for the new name. PrintAsObjC, however, didn't expect to see typealiases with Clang nodes that weren't typedefs or Objective-C classes. Add support for these kinds of typealiases by doing the same thing we'd do for an underlying struct type.
- Scope: Affects use of typealiases created by the ClangImporter in APIs that are exposed in the generated Objective-C header.
- Radar: rdar://problem/32514335
- Reviewed by: @milseman
- Risk: Low. Uses existing code paths to handle this case.
- Testing: Passed compiler regression test, confirmed that the original test case now generates correct headers.
…lang#10042) These are TypeAliasDecls whose Clang nodes are not TypedefNameDecls. This worked all right for classes, but dropped the tag keyword (e.g. 'struct') for tag decls with names of their own, and didn't print any name at all for C types that used the typedef-for-anonymous-tag pattern. rdar://problem/32514335
|
@swift-ci Please test |
|
@swift-ci test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.