[GSB] Resolve nested types by looking into superclass constraints. #10049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilities functions used when comparing declaration contexts. Only the syntactic form is currently used (for the owning DC of a generic environment).
…eclarations. Generalizes ProtocolType::compareProtocols() for more general use.
… types. Potential archetypes can resolve to either an associated type or a typealias. Generalize the latter to "any concrete type", both because the current implementation is unnecessarily narrow (typealiases aren't actually special in this regard) and to get us closer to handling lookups via superclass constraints when resolving these types.
This was previously handled very late, by the type checker, which led to weird ordering dependencies and meant that we could end up with well-formed code where the GSB was left with unresolved types. We want such states to never exist, so make sure we can resolve everything in the GSB.
DougGregor
force-pushed
the
gsb-superclass
branch
from
1e22e0c to
4fbb3ec
Compare
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously handled very late, by the type checker, which led
to weird ordering dependencies and meant that we could end up with
well-formed code where the GSB was left with unresolved types. We want
such states to never exist, so make sure we can resolve everything in
the GSB.