[4.0][SourceKit] If diagnostics are 'stale' for a particular snapshot then ignore them and only return the syntactic parser diagnostics #10408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ignore them and only return the syntactic parser diagnostics (swiftlang#10388) This makes sure that diagnostics returned for a particular state of source buffer are consistent and accurate. rdar://32769873
|
@swift-ci Please test |
|
Explanation: While edits are occurring in the Xcode editor sourcekitd may return diagnostics that refer to a previous state of the source, until they get cleared once the latest source version is typechecked. With large source files that take long to typecheck this can lead to an experience of 'lingering' stale diagnostics. The commit makes changes to make things more clear and consistent and avoid returning 'stale' diagnostics, that refer to a previous version of the source, as response to edits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://32769873
master: #10388