-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Introduce BenchmarkInfo and BenchmarkCategories. #12048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci smoke benchmark. |
Build comment file:Build failed before running benchmark. |
When a benchmark is added, it's name will be manually added to CMakeLists and main.swift. Adding a benchmark no longer requires discovering a nonobvious script. If the build works locally, then it will work everywhere else. Note that generate_harness.py should now be renamed to generate_benchmarks.py, but I think it's name may be hard-coded somewhere in the compiler tests. Anyway, this script should go away as soon as someone fixes the cmake configuration to automatically run gyb.
@swift-ci benchmark. |
@swift-ci smoke test. |
Build comment file:Build failed before running benchmark. |
@swift-ci smoke test. |
@swift-ci smoke benchmark. |
Build comment file:Build failed before running benchmark. |
@shahmishal Any idea why @swift-ci benchmark keeps failing? |
@swift-ci smoke benchmark. |
Build comment file:Optimized (O)Regression (7)
Improvement (14)
No Changes (307)
Unoptimized (Onone)Regression (6)
Improvement (6)
No Changes (316)
Hardware Overview
|
palimondo
added a commit
to palimondo/swift
that referenced
this pull request
Nov 28, 2018
After commit aaece4f from PR swiftlang#12048, this was just a dead code.
PopFlamingo
pushed a commit
to PopFlamingo/swift
that referenced
this pull request
Dec 6, 2018
After commit aaece4f from PR swiftlang#12048, this was just a dead code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.