Sema: Fix a failure to emit a diagnostic [4.0] #12150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSDiag was misinterpreting the result of checkGenericArguments(). A result of SubstitutionFailure does not mean a diagnostic was emitted, only a result of Failure means that. This fixes a case where we did not emit a diagnostic, result in a crash on invalid. The diagnostic is still poor, but that's better than crashing. Fixes <https://bugs.swift.org/browse/SR-5932>, <rdar://problem/34522739>.
|
@swift-ci Please test |
|
@DougGregor Can you review this for 4.0? |
slavapestov
changed the title
This was referenced Oct 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fix a crash on invalid that seems to be pretty common when people expect an array of hashables to be hashable but it's not.
Risk: Very low, this is a logic change to diagnostics, instructing it to keep going in a case where no diagnostic was emitted.
Tested: New test added.
Radar: rdar://problem/34522739
Reviewed by: @DougGregor