Fixed faulty boolean logic #12965
Merged
Fixed faulty boolean logic #12965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a trivial logic error. The "abort" condition would be followed only if `c == 0` with other clauses having no effect.
|
@swift-ci please smoke test |
|
Hm, this should still be good. @swift-ci please smoke test |
|
For testing: an invalid name would be 'ss4testCTeax_' (compared to the valid name of 'ss4testCTean_' |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a trivial logic error. The "abort" condition would be followed only if
c == 0with other clauses having no effect. The error was found by code inspection not testing; it is not associated with any known bugs or problems. You'd need to be demangling a non-conforming string to trigger it and the effort might not be worth it.With the
!c &&clause dropped, the logic is in accordance with:https://github.com/apple/swift/blob/master/docs/ABI/Mangling.rst
which states the the only valid chars at this point are
norb.