Skip to content

[Foundation] searching in slices should index relative to the slice (4.1) #14852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2018
Merged

[Foundation] searching in slices should index relative to the slice (4.1) #14852

merged 1 commit into from
Feb 28, 2018

Conversation

phausler
Copy link
Contributor

Searching in slices incorrectly passed the base index rather than the relative slice indexes. This change adjusts the indexing for searching in slices to be relative.

This addresses the following issues
https://bugs.swift.org/browse/SR-5209
rdar://problem/36261057

Tests were added to validate this failure has been addressed (kudos to the filer of the issue for providing a good unit test)

@phausler
Copy link
Contributor Author

@swift-ci please test

@phausler phausler requested a review from parkera February 27, 2018 16:18
parkera
parkera approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@parkera parkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you double check Swift-corelibs as well?

@phausler
Copy link
Contributor Author

The flaw exists there too so I will duplicate it back here shortly to swift-corelibs

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 1f72852a4e726ba8efef4e62563dc4697dd51867

@phausler phausler force-pushed the pr/data_range_of_slice_4.1 branch from 1f72852 to 1101135 Compare February 27, 2018 18:09
@phausler
Copy link
Contributor Author

@swift-ci please smoke test

@phausler phausler force-pushed the pr/data_range_of_slice_4.1 branch from 1101135 to fd5813a Compare February 27, 2018 20:25
@phausler
Copy link
Contributor Author

@swift-ci Please nominate

Explanation: Data indexes passed to a bridged context in searching were incorrect
Scope: This is limited to searching of slices of Data
Radar:rdar://problem/36261057
Origination: Internal & third-party reports (SR-5209)
Risk: Low
Reviewed by: @parkera
Testing: Adds new unit tests to catch regressions to this behavior

@phausler
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 1f72852a4e726ba8efef4e62563dc4697dd51867

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 1f72852a4e726ba8efef4e62563dc4697dd51867

@phausler
Copy link
Contributor Author

@swift-ci please test

@phausler phausler merged commit 08ee342 into swiftlang:swift-4.1-branch Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parkera parkera parkera approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phausler @swift-ci @parkera