[4.1][SourceKitd] Avoid printing parent type directly on extended type. rdar://37965902 #14909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nkcsgexi
commented
Mar 1, 2018
nkcsgexi
commented
- Explanation: When we print the parent type of an extended type, we used to print sugared type with generic arguments. This looks wired for interface and documentation generation. To fix this issue, the patch simply changes the API to use so that the parent type is printed as unbound and unsugared.
- Scope: IDE interface printing; documentation generation
- Risk: Very low
- Testing: Regression tests added
- Reviewer: @huonw
- Radar: rdar://37965902
|
@swift-ci please test |
|
Build failed |
|
Build failed |
…ar://37965902 When printing parent type directly, we may print generic arguments and sugared dictionary type.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.