[SR-7040] Redundant prefix of compilation flag specific error #14950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nonchalant
force-pushed
the
sr_7040_redundant_D
branch
from
20d650d to
3fca891
Compare
jrose-apple
reviewed
Mar 3, 2018
| @@ -209,6 +209,10 @@ ERROR(symbol_in_ir_not_in_tbd,none, | |||
| "symbol '%0' (%1) is in generated IR file, but not in TBD file", | |||
| (StringRef, StringRef)) | |||
|
|
|||
| ERROR(redundant_prefix_compilation_flag,none, | |||
| "did you provide a redundant '-D' in your build settings? (got '-D%0')", | |||
There was a problem hiding this comment.
We usually try to say what went wrong first and then offer a suggestion, so maybe something more like "invalid argument '-D%0'; did you…"?
There was a problem hiding this comment.
Thank you! I will try to fix message!! ✨
jrose-apple
approved these changes
Mar 5, 2018
|
Looks great! @swift-ci Please smoke test |
|
Disabled failed test in #15005 |
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode (and possibly other IDEs) provide a UI over -D flags where you provide the flag name and -D is prepended for you. Users might reasonably add a redundant -D themselves, leading to the invalid flag
-D-DFOOgetting passed into the compiler. The driver could detect this and raise a specific error message alerting the user to their mistake.Resolves SR-7040.