Skip to content

Conversation

eeckstein
Copy link
Contributor

@eeckstein
Copy link
Contributor Author

@swift-ci smoke test and merge

@xwu
Copy link
Collaborator

xwu commented Mar 9, 2018

Sigh. Sorry about this. I will look into it today.

@stephentyrone
Copy link
Contributor

stephentyrone commented Mar 9, 2018

Thanks @eeckstein.

@xwu I think you really want to replace the bitwiseExact test with an isNaN check.

@xwu
Copy link
Collaborator

xwu commented Mar 9, 2018

I do. I very much do.

I thought that at the very least platforms would agree that .nan + 0 would give back .nan, so that any future failure would tell us something interesting about bit pattern changes that may not be intentional. This serves me right; I'll get rid of it right away.

@eeckstein eeckstein merged commit 784dea7 into swiftlang:master Mar 9, 2018
@eeckstein
Copy link
Contributor Author

@xwu Thanks for fixing this! Please re-enable the test once its fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants