Skip to content

Conversation

tkremenek
Copy link
Member

The effective version for 4.x may be greater than '2', even with -swift-version 4.2. However, that should be canonicalized to 4.2.

@tkremenek
Copy link
Member Author

@swift-ci please smoke test

@tkremenek tkremenek requested a review from jrose-apple March 26, 2018 17:56
@jrose-apple
Copy link
Contributor

Strictly speaking I should ask you for a test… ;-) That can be a follow-up commit.

@tkremenek
Copy link
Member Author

tkremenek commented Mar 26, 2018

@jrose-apple A test is reasonable. What do you suggest? Currently the driver only accepts -swift-version 4.2, etc. The notion here was that the current tests should suffice when the effective version bumps up to something like (say) 4.3 under -swift-version 4.2 mode, if we decide to go that route. This is about future proofing on later version changes to the compiler.

If there is a good way to write a unit test here, happy to do so.

@jrose-apple
Copy link
Contributor

You could write a gtest-style test instead, like unittests/Basic/SourceManagerTest.cpp.

@tkremenek tkremenek merged commit 8c11487 into swiftlang:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants