[4.2 03-26-2018] SILGen: Don't postpone the cleanup of the convertEscapeToNoEsca… #15612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce SILGenBuilder::createConvertEscapeToNoEscape() to correctly handle ownership, and switch all relevant callers to it.
…alive. Thanks, Arnold!
…pe inside an bind optional This would violate dominance since the convertEscapeToNoEscape instruction does not dominate the postpone point. rdar://38124009 * Ensure lifetimes of optional convert_escape_to_noescape closures
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
…_noescape [not_guaranteed] operand Either through a peephole or we keep the closure operand alive to the end of the function rdar://38124009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pe inside an bind optional
This would violate dominance since the convertEscapeToNoEscape
instruction does not dominate the postpone point.