[+0-all-args] Remove autoreleasepool on non-x86_64 platforms from Str… #15686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing stubs. This is only necessary on x86-64. On arm/arm64 we are already ok since the assembly marker that we use there does not suffer from this issue. For x86-64 we need to solve the problem upstream by not tailing calling objc_retainAutoreleasedReturnValue. rdar://38675842
|
@swift-ci test and merge |
|
Where is the bug report for fixing x86_64's incorrect tail call to |
|
It is a bug in clang. There is a radar for it: rdar://38675842. I am in the process of fixing it. But that doesn't mean that in the mean time we shouldn't do the right thing for other platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing stubs.
This is only necessary on x86-64. On arm/arm64 we are already ok since the
assembly marker that we use there does not suffer from this issue.
For x86-64 we need to solve the problem upstream by not tailing calling
objc_retainAutoreleasedReturnValue.
rdar://38675842