[Batch mode] <rdar://40167848> Merge pull request #16526 from davidungar/compilation-failed #16596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Batch Mode] Emit a non-specific error for all primaries lacking specific errors when a batch has errors.
|
@swift-ci please test |
|
@swift-ci please nominate |
davidungar
changed the title
davidungar
deleted the
rdar-40167848-nonspecific-error-swift-4.2-4-30-2018-branch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Batch Mode] Emit a non-specific error for all primaries lacking specific errors when a batch has errors.
Explanation: In batch mode an error in any file stops compilation of all (primary) files. Issue a nonspecific error to any primary file that has no other error/
Scope of issue: User experience when using batch mode in, e.g. Xcode.
Origination: Batch mode/Xcode interaction.
Risk: May be confusing, but less confusing than no error.
Reviewed by: Jordan Rose
Testing: Normal regression tests.
Radar: rdar://40167848
Resolves SR-NNNN.