[stdlib] Remove theGlobalMT19937
#16650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benrimmington
commented
May 16, 2018
|
@swift-ci please test |
lorentey
reviewed
Jul 2, 2018
benrimmington
force-pushed
the
remove-the-global-mt19937
branch
from
a4b5822 to
c8531a5
Compare
benrimmington
commented
Jul 6, 2018
benrimmington
force-pushed
the
remove-the-global-mt19937
branch
5 times, most recently
from
e195f8c to
e29c063
Compare
SwiftPrivate/PRNG.swift: - currently uses `theGlobalMT19937`; - previously used `arc4random` (see swiftlang#1939); - is obsoleted by SE-0202: Random Unification.
benrimmington
force-pushed
the
remove-the-global-mt19937
branch
from
e29c063 to
2f326bc
Compare
|
@lorentey Please take another look at this if you can. I've added the |
|
Sorry about the delay! @swift-ci test |
lorentey
approved these changes
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftPrivate/PRNG.swift:
theGlobalMT19937;arc4random(see [stdlib] Portable random function #1939);