Skip to content

[GSB] Use a larger set for checking for visited requirements in 'isRecursive'. #16673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2018
Merged

[GSB] Use a larger set for checking for visited requirements in 'isRecursive'. #16673

merged 1 commit into from
May 17, 2018
+1 −1

Conversation

huonw
Copy link
Contributor

@huonw huonw commented May 17, 2018

This claws back some of the regression of
2feb830 on certain generics heavy code.

rdar://problem/40005262 (no-opt) goes from 7.83 -> 5.75 and
rdar://problem/40010847 (opt) goes from 90.7 -> 66.6 (both -27%).

@huonw
[GSB] Use a larger set for checking for visited requirements in 'isRe…
ff77966 
…cursive'.

This claws back some of the regression of
2feb830 on certain generics heavy code.

rdar://problem/40005262 (no-opt) goes from 7.83 -> 5.75 and
rdar://problem/40010847 (opt) goes from 90.7 -> 66.6 (both -27%).
@huonw
Copy link
Contributor Author

huonw commented May 17, 2018

@swift-ci please smoke test

@huonw
Copy link
Contributor Author

huonw commented May 17, 2018

@swift-ci please benchmark compiler performance

@huonw
Copy link
Contributor Author

huonw commented May 17, 2018

@swift-ci please test compiler performance

Oops.

@huonw
Copy link
Contributor Author

huonw commented May 17, 2018

@swift-ci Please test compiler performance

@swift-ci
Copy link
Contributor

Build comment file:

Summary for master full

Unexpected test results, excluded stats for ProcedureKit, StencilSwiftKit, ObjectMapper, Core

No regressions above thresholds

Debug-batch

debug-batch brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 1,595,622,792 1,594,982,298 -640,494 -0.04%
time.swift-driver.wall 2278.4s 2272.6s -5.8s -0.25%

debug-batch detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (74)
name old new delta delta_pct
AST.NumASTBytesAllocated 29,743,083,127 29,741,722,226 -1,360,901 -0.0%
AST.NumDecls 91,049 91,049 0 0.0%
AST.NumDependencies 162,144 162,144 0 0.0%
AST.NumImportedExternalDefinitions 1,450,771 1,450,771 0 0.0%
AST.NumInfixOperators 28,811 28,811 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 210,580 210,580 0 0.0%
AST.NumLocalTypeDecls 16 16 0 0.0%
AST.NumObjCMethods 27,456 27,456 0 0.0%
AST.NumPostfixOperators 14 14 0 0.0%
AST.NumPrecedenceGroups 18,184 18,184 0 0.0%
AST.NumPrefixOperators 134 134 0 0.0%
AST.NumReferencedDynamicNames 208 208 0 0.0%
AST.NumReferencedMemberNames 4,093,284 4,093,284 0 0.0%
AST.NumReferencedTopLevelNames 305,021 305,021 0 0.0%
AST.NumSourceBuffers 407,985 407,985 0 0.0%
AST.NumSourceLines 2,753,771 2,753,771 0 0.0%
AST.NumSourceLinesPerSecond 1,906,122 1,924,817 18,695 0.98%
AST.NumTotalClangImportedEntities 4,706,214 4,706,214 0 0.0%
AST.NumUsedConformances 220,613 220,613 0 0.0%
Driver.ChildrenMaxRSS 69,122,240,512 68,951,914,496 -170,326,016 -0.25%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 18,583 18,583 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumDriverPipePolls 244,377 242,614 -1,763 -0.72%
Driver.NumDriverPipeReads 269,375 268,656 -719 -0.27%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.NumProcessFailures 0 0 0 0.0%
IRModule.NumIRAliases 14,404 14,404 0 0.0%
IRModule.NumIRBasicBlocks 4,231,455 4,231,455 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 2,363,915 2,362,609 -1,306 -0.06%
IRModule.NumIRGlobals 2,477,855 2,477,855 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 48,143,490 48,136,993 -6,497 -0.01%
IRModule.NumIRNamedMetaData 72,990 72,990 0 0.0%
IRModule.NumIRValueSymbols 4,290,061 4,288,755 -1,306 -0.03%
LLVM.NumLLVMBytesOutput 1,595,622,792 1,594,982,298 -640,494 -0.04%
Parse.NumFunctionsParsed 166,258 166,258 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 1,605,694 1,605,694 0 0.0%
SILModule.NumSILGenGlobalVariables 27,022 27,022 0 0.0%
SILModule.NumSILGenVtables 16,867 16,867 0 0.0%
SILModule.NumSILGenWitnessTables 46,504 46,504 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 1,506,382 1,506,382 0 0.0%
SILModule.NumSILOptGlobalVariables 54,601 54,601 0 0.0%
SILModule.NumSILOptVtables 26,169 26,169 0 0.0%
SILModule.NumSILOptWitnessTables 81,867 81,867 0 0.0%
Sema.NamedLazyMemberLoadFailureCount 24,756 24,756 0 0.0%
Sema.NamedLazyMemberLoadSuccessCount 4,192,777 4,192,777 0 0.0%
Sema.NominalTypeLookupDirectCount 31,125,158 31,125,158 0 0.0%
Sema.NumConformancesDeserialized 5,278,747 5,278,747 0 0.0%
Sema.NumConstraintScopes 13,241,586 13,241,586 0 0.0%
Sema.NumConstraintsConsideredForEdgeContraction 31,897,847 31,897,847 0 0.0%
Sema.NumDeclsDeserialized 35,755,318 35,755,318 0 0.0%
Sema.NumDeclsValidated 3,214,051 3,214,051 0 0.0%
Sema.NumFunctionsTypechecked 973,098 973,098 0 0.0%
Sema.NumGenericSignatureBuilders 1,750,091 1,750,091 0 0.0%
Sema.NumLazyGenericEnvironments 6,699,809 6,699,809 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 731,927 731,927 0 0.0%
Sema.NumLazyIterableDeclContexts 5,676,354 5,676,354 0 0.0%
Sema.NumTypesDeserialized 37,899,475 37,899,475 0 0.0%
Sema.NumTypesValidated 4,240,512 4,240,512 0 0.0%
Sema.NumUnloadedLazyIterableDeclContexts 3,754,493 3,754,493 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 1,488,101,200 1,487,990,002 -111,198 -0.01%
time.swift-driver.wall 3821.2s 3838.4s 17.2s 0.45%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 684,811 685,208 397 0.06%
AST.NumLoadedModules 81,497 81,559 62 0.08%
AST.NumTotalClangImportedEntities 2,242,385 2,244,169 1,784 0.08%
AST.NumUsedConformances 225,505 226,078 573 0.25%
IRModule.NumIRBasicBlocks 3,701,247 3,708,064 6,817 0.18%
IRModule.NumIRFunctions 1,942,098 1,944,996 2,898 0.15%
IRModule.NumIRGlobals 2,100,467 2,103,364 2,897 0.14%
IRModule.NumIRInsts 35,095,804 35,140,328 44,524 0.13%
IRModule.NumIRValueSymbols 3,693,446 3,698,825 5,379 0.15%
LLVM.NumLLVMBytesOutput 1,488,101,200 1,487,990,002 -111,198 -0.01%
SILModule.NumSILGenFunctions 838,312 839,544 1,232 0.15%
SILModule.NumSILOptFunctions 1,348,349 1,352,737 4,388 0.33%
Sema.NumConformancesDeserialized 4,230,776 4,247,929 17,153 0.41%
Sema.NumConstraintScopes 13,147,985 13,175,419 27,434 0.21%
Sema.NumDeclsDeserialized 18,535,998 18,577,449 41,451 0.22%
Sema.NumDeclsValidated 2,665,918 2,669,689 3,771 0.14%
Sema.NumFunctionsTypechecked 605,063 605,658 595 0.1%
Sema.NumGenericSignatureBuilders 974,951 976,006 1,055 0.11%
Sema.NumLazyGenericEnvironments 3,471,696 3,478,932 7,236 0.21%
Sema.NumLazyGenericEnvironmentsLoaded 344,822 345,413 591 0.17%
Sema.NumLazyIterableDeclContexts 2,732,163 2,736,190 4,027 0.15%
Sema.NumTypesDeserialized 21,897,882 21,949,828 51,946 0.24%
Sema.NumTypesValidated 3,509,026 3,510,593 1,567 0.04%

@huonw huonw merged commit fabb5ab into swiftlang:master May 17, 2018
@huonw huonw deleted the GSB-opts branch May 17, 2018 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huonw @swift-ci