[Serialization] Fix message for using an older compiler's module file #17340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously: "module compiled with Swift 4.1 cannot be imported in Swift 4.1.50" (i.e. following the -swift-version flag) Now: "module compiled with Swift 4.1 cannot be imported by the Swift 4.2 compiler" I'm pretty sure this is what I intended to do all along, and I just messed it up when I originally implemented it. This is especially important when working with downloadable toolchains, which would say "module compiled with Swift 4.2 cannot be imported in Swift 4.1.50", which is not really the problem at all. Now it'll fall back to the more generic "module file was created by an older version of the compiler" error.
jrose-apple
commented
Jun 19, 2018
| @@ -293,7 +294,7 @@ FileUnit *SerializedModuleLoader::loadAST( | |||
|
|
|||
| SmallString<32> versionBuf; | |||
| llvm::raw_svector_ostream versionString(versionBuf); | |||
| versionString << Ctx.LangOpts.EffectiveLanguageVersion; | |||
| versionString << Version::getCurrentLanguageVersion(); | |||
There was a problem hiding this comment.
|
@swift-ci Please smoke test |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Jun 25, 2018
…swiftlang#17340) Previously: "module compiled with Swift 4.1 cannot be imported in Swift 4.1.50" (i.e. following the -swift-version flag) Now: "module compiled with Swift 4.1 cannot be imported by the Swift 4.2 compiler" I'm pretty sure this is what I intended to do all along, and I just messed it up when I originally implemented it. This is especially important when working with downloadable toolchains, which would say "module compiled with Swift 4.2 cannot be imported in Swift 4.1.50", which is not really the problem at all. Now it'll fall back to the more generic "module file was created by an older version of the compiler" error. (cherry picked from commit 2c40c6b)
jrose-apple
added a commit
that referenced
this pull request
Jun 25, 2018
…#17340) (#17474) Previously: "module compiled with Swift 4.1 cannot be imported in Swift 4.1.50" (i.e. following the -swift-version flag) Now: "module compiled with Swift 4.1 cannot be imported by the Swift 4.2 compiler" I'm pretty sure this is what I intended to do all along, and I just messed it up when I originally implemented it. This is especially important when working with downloadable toolchains, which would say "module compiled with Swift 4.2 cannot be imported in Swift 4.1.50", which is not really the problem at all. Now it'll fall back to the more generic "module file was created by an older version of the compiler" error. (cherry picked from commit 2c40c6b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: "module compiled with Swift 4.1 cannot be imported in Swift 4.1.50" (i.e. following the -swift-version flag)
Now: "module compiled with Swift 4.1 cannot be imported by the Swift 4.2 compiler"
I'm pretty sure this is what I intended to do all along, and I just messed it up when I originally implemented it. This is especially important when working with downloadable toolchains, which would say "module compiled with Swift 4.2 cannot be imported in Swift 4.1.50", which is not really the problem at all. Now it'll fall back to the more generic "module file was created by an older version of the compiler" error.