Skip to content

[stdlib]Specialize remaining 4.2 #17674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2018
Merged

[stdlib]Specialize remaining 4.2 #17674

merged 1 commit into from
Jul 2, 2018

Conversation

lancep
Copy link
Contributor

@lancep lancep commented Jul 2, 2018 •
edited
Loading

Cherry-pick from 78e9e90 for 4.2

  • Explanation: Hashing some non-ascii strings got slower in Swift 4.2. This was caused by some generic code that didn't get specialized by the optimizer. This change hand specializes that code.
  • Scope of Issue: The majority of strings hashed should not hit this code path, but it is a regression for some non-ascii strings.
  • Origination: March 2018, we unified the hashing approaches for Darwin and Linux platforms
  • Risk: Minimal
  • Reviewed By: Karoy Lorentey and Michael Ilseman
  • Dependencies: None
  • Testing: Benchmarks and automated test suite

rdar://problem/41734165

@lancep lancep changed the base branch from master to swift-4.2-branch July 2, 2018 19:04
@lancep
Copy link
Contributor Author

lancep commented Jul 2, 2018

@swift-ci please smoke benchmark

@lancep
Copy link
Contributor Author

lancep commented Jul 2, 2018

@swift-ci please test

@lancep lancep changed the title Specialize remaining 4.2 [stdlib]Specialize remaining 4.2 Jul 2, 2018
@swift-ci
Copy link
Contributor

swift-ci commented Jul 2, 2018

Build comment file:

Build failed before running benchmark.

@lancep lancep requested review from milseman and lorentey July 2, 2018 20:51
@lancep lancep merged commit 89b4664 into swiftlang:swift-4.2-branch Jul 2, 2018
@lancep lancep deleted the specialize_remaining_4.2 branch July 2, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milseman milseman Awaiting requested review from milseman

@lorentey lorentey Awaiting requested review from lorentey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lancep @swift-ci