Skip to content

Conversation

airspeedswift
Copy link
Member

Note, this is a 4.2-only PR. The 5.0 version renames the type and type aliases the old type, here: #16577.

Adding this typealias now will allow people to make the change on code that will still compile on the (future) old compiler, allowing us to deprecate the old name in 5.0 mode.

@airspeedswift
Copy link
Member Author

@swift-ci please test

Copy link
Member

@milseman milseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lancep lancep self-requested a review July 3, 2018 23:08
Copy link
Contributor

@lancep lancep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@airspeedswift airspeedswift merged commit dd01269 into swiftlang:swift-4.2-branch Jul 4, 2018
@airspeedswift airspeedswift deleted the kvp-typealias branch July 4, 2018 00:04
benrimmington added a commit to benrimmington/swift that referenced this pull request Aug 24, 2018
airspeedswift pushed a commit that referenced this pull request Aug 27, 2018
* renamed DictionaryLiteral to KeyValuePairs per SE-0214

* renamed DictionaryLiteral type tests to KeyValuePairs

* [SE-0214] Move changelog entry (Swift 4.2 => 5.0)

* [SE-0214] Update comment in AST/Expr.h

* [SE-0214] Use generic typealias

See also <#17711>

* [SE-0214] Update source-stability.swift.expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants