Minor IRGen cleanups #18697
Merged
Minor IRGen cleanups #18697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments We don't need to substitute the superclass type as we walk up a class hierarchy, or look up the generic parameters and conformances to check if they're concrete, since we're always just emitting null pointers in place of the generic parameters and requirements, to be filled at runtime. Also, don't leave space for generic parameters and requirements from Objective-C superclasses, since that's not how they're represented.
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
minor-irgen-cleanups
branch
from
207e828 to
24677e9
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
slavapestov
force-pushed
the
minor-irgen-cleanups
branch
from
24677e9 to
dffcafb
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly NFC, but the NominalMetadataVisitor change means we request the superclass type of a class in fewer places, which should help with request evaluator work.