[4.2] [SILGen] Forming transitive capture lists, need to unique on value not value+flags #18701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l to appear in the transitive capture list only once, not potentially repeated with different flags.
…ll be more clear that dealing with this will be required if more flags are added in the future. And mergeFlags correctly on the dynamic self capture.
|
@swift-ci Please test |
|
@swift-ci Please nominate |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: When capturing from a nested context, we would treat the captured value as a distinct variable in the nested context, causing the variable to be copied instead of shared with the outer context.
Scope: Silent miscompile. Regression from 4.1
Issue: SR-8398 | rdar://problem/42742744
Risk: Low, the change is limited in scope and should only impact capture emission.
Testing: Swift CI, test case from SR, compatibility suite
Author: @gregomni
Reviewed by: @slavapestov