Skip to content

Assume it's okay for decls in a cross-module extension to be public #18741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2018
Merged

Assume it's okay for decls in a cross-module extension to be public #18741

merged 1 commit into from
Aug 16, 2018

Conversation

jrose-apple
Copy link
Contributor

...even if the base decl isn't.

This isn't normally possible, but it can come up when an imported type is import-as-member'd onto an internal Swift declaration. This isn't even such an unreasonable thing to do, since internal Swift declarations are exposed in the generated header for an app.

rdar://problem/43312660

@jrose-apple
Assume it's okay for decls in a cross-module extension to be public
990fff8 
...even if the base decl isn't.

This isn't normally possible, but it can come up when an imported type
is import-as-member'd onto an internal Swift declaration. This isn't
even such an unreasonable thing to do, since internal Swift
declarations are exposed in the generated header for an app.

rdar://problem/43312660
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test source compatibility

DougGregor
DougGregor approved these changes Aug 15, 2018
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Wow. LGTM

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 990fff8

@jrose-apple
Copy link
Contributor Author

@vedantk:

20:00:40 Failing Tests (2):
20:00:40 lldb-Suite :: functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py
20:00:40 lldb-Suite :: tools/lldb-mi/interpreter/TestMiInterpreterExec.py

(https://ci.swift.org/job/swift-PR-Linux/6841/)

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test Linux

@jrose-apple
Copy link
Contributor Author

Okay, this is running more slowly than I expected, so

@swift-ci Please test compiler performance

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 990fff8

@swift-ci
Copy link
Contributor

Build comment file:

Summary for master full

Unexpected test results, excluded stats for RxSwift, ReactiveCocoa, Wordy, DatabaseKit, ReactiveSwift

No regressions above thresholds

Debug-batch

debug-batch brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructions 10,095,817,880,390 10,100,205,041,785 4,387,161,395 0.04%
LLVM.NumLLVMBytesOutput 505,223,084 505,223,062 -22 -0.0%
time.swift-driver.wall 1160.7s 1169.0s 8.4s 0.72%

debug-batch detailed

Regressed (0)
name old new delta delta_pct
Improved (2)
name old new delta delta_pct
Driver.NumDriverPipePolls 83,418 82,508 -910 -1.09% ✅
Driver.NumDriverPipeReads 86,492 85,563 -929 -1.07% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (87)
name old new delta delta_pct
AST.NumASTBytesAllocated 13,686,240,293 13,685,972,184 -268,109 -0.0%
AST.NumDecls 33,060 33,060 0 0.0%
AST.NumDependencies 88,576 88,576 0 0.0%
AST.NumImportedExternalDefinitions 816,564 816,564 0 0.0%
AST.NumInfixOperators 13,323 13,323 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 100,529 100,529 0 0.0%
AST.NumLocalTypeDecls 13 13 0 0.0%
AST.NumObjCMethods 12,906 12,906 0 0.0%
AST.NumPostfixOperators 14 14 0 0.0%
AST.NumPrecedenceGroups 6,996 6,996 0 0.0%
AST.NumPrefixOperators 60 60 0 0.0%
AST.NumReferencedDynamicNames 45 45 0 0.0%
AST.NumReferencedMemberNames 1,899,880 1,899,880 0 0.0%
AST.NumReferencedTopLevelNames 115,797 115,797 0 0.0%
AST.NumSourceBuffers 151,378 151,367 -11 -0.01%
AST.NumSourceLines 1,198,590 1,198,590 0 0.0%
AST.NumSourceLinesPerSecond 697,596 693,871 -3,725 -0.53%
AST.NumTotalClangImportedEntities 2,642,117 2,642,117 0 0.0%
AST.NumUsedConformances 101,090 101,090 0 0.0%
Driver.ChildrenMaxRSS 34,628,743,168 34,582,691,840 -46,051,328 -0.13%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 7,072 7,072 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.NumInstructions 10,095,817,880,390 10,100,205,041,785 4,387,161,395 0.04%
Frontend.NumProcessFailures 0 0 0 0.0%
IRModule.NumIRAliases 26,417 26,417 0 0.0%
IRModule.NumIRBasicBlocks 1,730,602 1,730,602 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 950,248 950,248 0 0.0%
IRModule.NumIRGlobals 1,163,441 1,163,441 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 20,379,959 20,379,959 0 0.0%
IRModule.NumIRNamedMetaData 34,928 34,928 0 0.0%
IRModule.NumIRValueSymbols 1,829,770 1,829,770 0 0.0%
LLVM.NumLLVMBytesOutput 505,223,084 505,223,062 -22 -0.0%
Parse.NumFunctionsParsed 63,471 63,471 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 948,428 948,428 0 0.0%
SILModule.NumSILGenGlobalVariables 14,900 14,900 0 0.0%
SILModule.NumSILGenVtables 3,966 3,966 0 0.0%
SILModule.NumSILGenWitnessTables 18,802 18,802 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 713,547 713,547 0 0.0%
SILModule.NumSILOptGlobalVariables 15,334 15,334 0 0.0%
SILModule.NumSILOptVtables 7,636 7,636 0 0.0%
SILModule.NumSILOptWitnessTables 36,779 36,779 0 0.0%
Sema.AccessLevelRequest 924,796 924,796 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 21,506 21,506 0 0.0%
Sema.EnumRawTypeRequest 7,688 7,688 0 0.0%
Sema.ExtendedNominalRequest 1,479,520 1,479,520 0 0.0%
Sema.InheritedDeclsReferencedRequest 56,238,328 56,238,328 0 0.0%
Sema.InheritedTypeRequest 26,183 26,183 0 0.0%
Sema.IsDynamicRequest 725,819 725,819 0 0.0%
Sema.IsObjCRequest 649,667 649,667 0 0.0%
Sema.NamedLazyMemberLoadFailureCount 14,826 14,826 0 0.0%
Sema.NamedLazyMemberLoadSuccessCount 2,202,306 2,202,306 0 0.0%
Sema.NominalTypeLookupDirectCount 15,566,815 15,566,806 -9 -0.0%
Sema.NumConformancesDeserialized 2,451,391 2,451,391 0 0.0%
Sema.NumConstraintScopes 7,336,400 7,336,400 0 0.0%
Sema.NumConstraintsConsideredForEdgeContraction 13,154,895 13,154,895 0 0.0%
Sema.NumDeclsDeserialized 16,547,503 16,547,503 0 0.0%
Sema.NumDeclsValidated 1,028,574 1,028,574 0 0.0%
Sema.NumFunctionsTypechecked 477,324 477,324 0 0.0%
Sema.NumGenericSignatureBuilders 787,177 787,177 0 0.0%
Sema.NumLazyGenericEnvironments 3,076,562 3,076,562 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 308,975 308,975 0 0.0%
Sema.NumLazyIterableDeclContexts 2,801,587 2,801,587 0 0.0%
Sema.NumTypesDeserialized 7,373,705 7,373,705 0 0.0%
Sema.NumTypesValidated 870,165 870,165 0 0.0%
Sema.NumUnloadedLazyIterableDeclContexts 1,906,168 1,906,168 0 0.0%
Sema.OverriddenDeclsRequest 1,497,828 1,497,828 0 0.0%
Sema.SelfBoundsFromWhereClauseRequest 50,582 50,582 0 0.0%
Sema.SetterAccessLevelRequest 56,039 56,039 0 0.0%
Sema.SuperclassDeclRequest 43,444,071 43,444,071 0 0.0%
Sema.SuperclassTypeRequest 15,741 15,741 0 0.0%
Sema.UnderlyingTypeDeclsReferencedRequest 1,628,313 1,628,313 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructions 11,944,452,651,705 11,945,867,862,787 1,415,211,082 0.01%
LLVM.NumLLVMBytesOutput 478,386,568 478,386,548 -20 -0.0%
time.swift-driver.wall 2109.8s 2116.7s 6.9s 0.32%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (23)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 146,087 146,087 0 0.0%
AST.NumLoadedModules 6,370 6,370 0 0.0%
AST.NumTotalClangImportedEntities 465,090 465,090 0 0.0%
AST.NumUsedConformances 103,289 103,289 0 0.0%
IRModule.NumIRBasicBlocks 1,705,251 1,705,251 0 0.0%
IRModule.NumIRFunctions 763,525 763,525 0 0.0%
IRModule.NumIRGlobals 883,631 883,631 0 0.0%
IRModule.NumIRInsts 14,686,245 14,686,245 0 0.0%
IRModule.NumIRValueSymbols 1,494,505 1,494,505 0 0.0%
LLVM.NumLLVMBytesOutput 478,386,568 478,386,548 -20 -0.0%
SILModule.NumSILGenFunctions 335,122 335,122 0 0.0%
SILModule.NumSILOptFunctions 452,939 452,939 0 0.0%
Sema.NumConformancesDeserialized 1,099,299 1,099,299 0 0.0%
Sema.NumConstraintScopes 7,239,654 7,239,654 0 0.0%
Sema.NumDeclsDeserialized 2,979,721 2,979,721 0 0.0%
Sema.NumDeclsValidated 548,486 548,486 0 0.0%
Sema.NumFunctionsTypechecked 172,322 172,322 0 0.0%
Sema.NumGenericSignatureBuilders 115,394 115,394 0 0.0%
Sema.NumLazyGenericEnvironments 501,320 501,320 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 58,075 58,075 0 0.0%
Sema.NumLazyIterableDeclContexts 329,254 329,254 0 0.0%
Sema.NumTypesDeserialized 1,868,517 1,868,517 0 0.0%
Sema.NumTypesValidated 273,787 273,787 0 0.0%

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test Linux

@jrose-apple jrose-apple merged commit 53e0fad into swiftlang:master Aug 16, 2018
@jrose-apple jrose-apple deleted the very-cross-with-you branch August 16, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov approved these changes

@DougGregor DougGregor DougGregor approved these changes

@graydon graydon Awaiting requested review from graydon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrose-apple @swift-ci @slavapestov @DougGregor