build: honour the libdispatch build type #18900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gottesmm @aschwaighofer - this might be an expedient way to get that mapped in via the build configuration |
|
@shahmishal is it possible to run the LSAN job via a PR? |
|
I just ran the LSAN bot configuration locally with this PR and It ran without errors. |
|
@swift-ci Please test |
|
@gottesmm You can use test with preset for LSAN testing. |
|
@shahmishal Thanks. |
|
@shahmishal That doesn't exist for Linux. Only for macOS. |
|
@gottesmm I will add the support for it in the future. |
|
I talked with Arnold/Compnerd. The change from Arnold's diff (the one posted in this PR) is needed to fix this. Compnerd is going to add that to the patch. |
When configuring libdispatch as part of the swift build on Linux with SourceKit enabled, we would default to a release build. However, that results in known leaks being reported with LSAN when building with a debug standard library. Pass along the `LIBDISPATCH_BUILD_TYPE` into the CMake build and map that to the CMAKE_BUILD_TYPE for the project.
compnerd
force-pushed
the
libdispatch-type
branch
from
0f05c7b to
df208b3
Compare
|
@swift-ci please test and merge |
gottesmm
approved these changes
Aug 22, 2018
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring libdispatch as part of the swift build on Linux with SourceKit
enabled, we would default to a release build. However, that results in known
leaks being reported with LSAN when building with a debug standard library.
Pass along the
LIBDISPATCH_BUILD_TYPEinto the CMake build and map that to theCMAKE_BUILD_TYPE for the project.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.