Refactoring ArgumentSource and PreparedArguments #19341
Merged
+144
−339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Source::isShuffle() Also, move the check to make it explicit that only a TupleShuffleExpr at the top level goes through the argument emission code path; a TupleShuffleExpr appearing inside a ParenExpr or TupleExpr is a tuple conversion, which is totally unrelated and emitted as an RValue. This is unfortunate and we should split off ArgumentShuffleExpr from TupleShuffleExpr, and eventually, fold ArgumentShuffleExpr into ApplyExpr.
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
…ser to their uses
…Param This solves a recently-added TODO, eliminating two usages of FunctionType::getInput() from SILGen.
slavapestov
force-pushed
the
silgen-argumentsource
branch
from
7965b1c to
8175552
Compare
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
Build failed |
|
@swift-ci Please test source compatibility |
rjmccall
approved these changes
Sep 16, 2018
|
@rjmccall Most uses of isScalar are straightforward to eliminate. For example if the apply argument is a TupleExpr we can split it up when building the PreparedArguments. The one exception is when the ArgumentSource is a TupleShuffleExpr. My plan there though is to build a tuple type explicitly and refactor it later. |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing usages of
AbstractionPattern::getFunctionInput()down. Getting close, but as you can see they're still there.