[CSStep] Add BindingStep to unify some logic in TypeVar, Disjunction steps
#19353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingStep` Unify `take` implementation and API for type variable and disjunction via `BindingStep` which accepts a producer.
|
@swift-ci please smoke test |
|
Can you add test cases that used to crash with a stack overflow and now diagnose “too complex”? (Or succeed, if you have any) |
|
@slavapestov Yes, I'm doing it in the separate PR, there are couple we are tracking. |
|
@swift-ci please ASAN test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify
takeimplementation and API for type variableand disjunction via
BindingStepwhich accepts a producer.And remove
TypeBindingclass which is no longer necessary.